Feature Requested: Limit Change Of Status

Limit Change Of Status

Please limit the changing of invoice status according to the same rules as edit invoice. To my thinking, it makes no sense to prohibit a user from performing Edit Invoice on another user's

SS

Scott Smith

Requested

Please limit the changing of invoice status according to the same rules as edit invoice.

To my thinking, it makes no sense to prohibit a user from performing Edit Invoice on another user’s invoices, but then to allow them to change the status of another user’s invoice from the List Invoices view.

  • MS

    Mian Saleem

    Answered

    Hello,

    I am not sure, if I can change this. There are many user with different requirements and from start this is the way to not edit other’s invoice.

    If you need, you can modify the edit method fo app/controllers/Sales.php and remove $this->sim->view_rights($inv->user_id);

    Thank you

  • SS

    Scott Smith

    Answered

    I’m not sure what that actually does, but it does not prevent changing the order status.

  • SS

    Scott Smith

    Answered

    I agree with preventing users from editing invoices other than their own. I have to let users VIEW all invoices, though, as that is necessary for customer service.

    However, any user can change the status of any invoice via the List Invoices view. It doesn’t matter if they created the invoice or not.

    What I am asking is, in the List Invoices view, to only allow users to change the status of the invoices they created.

  • MS

    Mian Saleem

    Answered

    Hello,

    It will allow users to edit other user’s sales. I misunderstand you request. I will fix this in next update.

    If you want user to see all the sales including other user’s sales, you can disbale Restrict Sales in settings.

    If you are asking to not allow users to udpate other’s sale status, then you can modify the update_status method of app/controllers/Sales.php and add the follwoing lines after line if ($id && $status) {

    $inv = $this->sales_model->getInvoiceByID($id);
    $this->sim->view_rights($inv->user_id);
    

    This is missing (mistake), I will add it in next udpate to not allow other to update status too.

    Thank you

  • SS

    Scott Smith

    Answered

    Yes, that is what I was trying to explain. I’m happy it is getting fixed. Thank you!

  • Login to Reply